Issue 173468: The first step towards fixing valgrind errors in the new hunspell....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173468: The first step towards fixing valgrind errors in the new hunspell.... (Closed)

Created:
11 years, 4 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
brettw, Mohamed Mansour

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/deps/

Visibility:
Public.

Description

The first step towards fixing valgrind errors in the new hunspell. This change fixes valgrind errors occured when running 'SpellCheckTest.SpellCheckStrings_EN_US' and 'SpellCheckTest.SpellCheckText'. It seems the original code forgots deleting a temporary buffer created in 'line = new char[]'. To avoid creating a temporary buffer, this change implements our own FileMgr class that encapsulates operations for reading a BDICT file, and put some of our hacks in the class. BUG=14756 TEST=chrome_test.sh -t unit --gtest_filter='SpellCheckTest.SpellCheckStrings_EN_US' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24590

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -240 lines)			Patch
M	third_party/hunspell128/src/hunspell/affixmgr.hxx	View	1 2	2 chunks	+1 line, -15 lines	0 comments	Download
M	third_party/hunspell128/src/hunspell/affixmgr.cxx	View	1 2 3	40 chunks	+34 lines, -225 lines	0 comments	Download
M	third_party/hunspell128/src/hunspell/filemgr.hxx	View	1 2	2 chunks	+26 lines, -0 lines	0 comments	Download
M	third_party/hunspell128/src/hunspell/filemgr.cxx	View	1 2	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

11 years, 4 months ago (2009-08-26 13:10:32 UTC) #2

LGTM! I missed that our BDict reader doesn't need those affix parse
functionality :( I thought the original code was the right way. Good spotting! I
like how you did the encapsulation class, very good. Cleaner code. Awesome work
:D

Expand Messages | Collapse Messages

Issue 173468: The first step towards fixing valgrind errors in the new hunspell.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages