Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1734643002: [fullcodegen] Factor out EmitNamedPropertyLoad. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1968 matching lines...) Expand 10 before | Expand all | Expand 10 after
1979 isolate()->factory()->empty_fixed_array()); 1979 isolate()->factory()->empty_fixed_array());
1980 __ mov(FieldOperand(eax, JSObject::kElementsOffset), 1980 __ mov(FieldOperand(eax, JSObject::kElementsOffset),
1981 isolate()->factory()->empty_fixed_array()); 1981 isolate()->factory()->empty_fixed_array());
1982 __ pop(FieldOperand(eax, JSIteratorResult::kValueOffset)); 1982 __ pop(FieldOperand(eax, JSIteratorResult::kValueOffset));
1983 __ mov(FieldOperand(eax, JSIteratorResult::kDoneOffset), 1983 __ mov(FieldOperand(eax, JSIteratorResult::kDoneOffset),
1984 isolate()->factory()->ToBoolean(done)); 1984 isolate()->factory()->ToBoolean(done));
1985 STATIC_ASSERT(JSIteratorResult::kSize == 5 * kPointerSize); 1985 STATIC_ASSERT(JSIteratorResult::kSize == 5 * kPointerSize);
1986 } 1986 }
1987 1987
1988 1988
1989 void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) {
1990 SetExpressionPosition(prop);
1991 Literal* key = prop->key()->AsLiteral();
1992 DCHECK(!key->value()->IsSmi());
1993 DCHECK(!prop->IsSuperAccess());
1994
1995 __ mov(LoadDescriptor::NameRegister(), Immediate(key->value()));
1996 __ mov(LoadDescriptor::SlotRegister(),
1997 Immediate(SmiFromSlot(prop->PropertyFeedbackSlot())));
1998 CallLoadIC(NOT_INSIDE_TYPEOF);
1999 }
2000
2001
2002 void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr, 1989 void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr,
2003 Token::Value op, 1990 Token::Value op,
2004 Expression* left, 1991 Expression* left,
2005 Expression* right) { 1992 Expression* right) {
2006 // Do combined smi check of the operands. Left operand is on the 1993 // Do combined smi check of the operands. Left operand is on the
2007 // stack. Right operand is in eax. 1994 // stack. Right operand is in eax.
2008 Label smi_case, done, stub_call; 1995 Label smi_case, done, stub_call;
2009 PopOperand(edx); 1996 PopOperand(edx);
2010 __ mov(ecx, eax); 1997 __ mov(ecx, eax);
2011 __ or_(eax, edx); 1998 __ or_(eax, edx);
(...skipping 2113 matching lines...) Expand 10 before | Expand all | Expand 10 after
4125 Assembler::target_address_at(call_target_address, 4112 Assembler::target_address_at(call_target_address,
4126 unoptimized_code)); 4113 unoptimized_code));
4127 return OSR_AFTER_STACK_CHECK; 4114 return OSR_AFTER_STACK_CHECK;
4128 } 4115 }
4129 4116
4130 4117
4131 } // namespace internal 4118 } // namespace internal
4132 } // namespace v8 4119 } // namespace v8
4133 4120
4134 #endif // V8_TARGET_ARCH_X87 4121 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698