Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 17346003: Don't restart browser if UserFlow isn't going to launch browser (Closed)

Created:
7 years, 6 months ago by Dmitry Polukhin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Don't restart browser if UserFlow isn't going to launch browser Fix regression introduced in https://chromiumcodereview.appspot.com/16770002/ BUG=251253 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207098

Patch Set 1 #

Total comments: 2

Patch Set 2 : swapped checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Polukhin
7 years, 6 months ago (2013-06-18 13:56:50 UTC) #1
Dmitry Polukhin
PTAL, I need OK from someone to fix locally managed user creation flow.
7 years, 6 months ago (2013-06-18 18:03:18 UTC) #2
zel
+xiyuan LGTM
7 years, 6 months ago (2013-06-18 18:13:06 UTC) #3
pastarmovj
https://codereview.chromium.org/17346003/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/17346003/diff/1/chrome/browser/chromeos/login/login_utils.cc#newcode305 chrome/browser/chromeos/login/login_utils.cc:305: if (!should_launch_browser) { Hey why not move the if ...
7 years, 6 months ago (2013-06-18 18:15:36 UTC) #4
Dmitry Polukhin
https://codereview.chromium.org/17346003/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/17346003/diff/1/chrome/browser/chromeos/login/login_utils.cc#newcode305 chrome/browser/chromeos/login/login_utils.cc:305: if (!should_launch_browser) { On 2013/06/18 18:15:36, pastarmovj wrote: > ...
7 years, 6 months ago (2013-06-18 18:40:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/17346003/9001
7 years, 6 months ago (2013-06-18 18:42:14 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 22:27:57 UTC) #7
Message was sent while issue was closed.
Change committed as 207098

Powered by Google App Engine
This is Rietveld 408576698