Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1734593004: Build PDFium with -std=c++11 instead of g++11. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/standalone.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
4 years, 10 months ago (2016-02-24 23:19:47 UTC) #2
Nico
lgtm (i'd add "instead of g++11" to the cl description else it kind of sounds ...
4 years, 10 months ago (2016-02-25 00:36:25 UTC) #3
Lei Zhang
On 2016/02/25 00:36:25, Nico wrote: > lgtm > > (i'd add "instead of g++11" to ...
4 years, 10 months ago (2016-02-25 00:53:32 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-25 00:54:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
969ea09df096b987662b9658e3ffa023ca4ebf70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698