Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: ash/root_window_controller_unittest.cc

Issue 173443002: aura: Take transformation into account when computing window bounds in root-window/screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | ui/aura/window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller_unittest.cc
diff --git a/ash/root_window_controller_unittest.cc b/ash/root_window_controller_unittest.cc
index be982d4c3cf1db1df7d9d98336411c391fb7cf53..4fd0ea2d91948ad3dfd3bc32e7d1ab6303b63c6f 100644
--- a/ash/root_window_controller_unittest.cc
+++ b/ash/root_window_controller_unittest.cc
@@ -153,8 +153,7 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
views::Widget* minimized = CreateTestWidget(gfx::Rect(800, 10, 100, 100));
minimized->Minimize();
EXPECT_EQ(root_windows[1], minimized->GetNativeView()->GetRootWindow());
- EXPECT_EQ("800,10 100x100",
- minimized->GetWindowBoundsInScreen().ToString());
+ EXPECT_TRUE(minimized->GetWindowBoundsInScreen().IsEmpty());
oshima 2014/02/20 19:39:35 Do you know why this becomes empty? AFAIK, the min
sadrul 2014/02/20 19:59:59 A transform is applied on he window on minimize, w
oshima 2014/02/20 20:18:51 Ah, I think it's coming from minimize animation. L
views::Widget* fullscreen = CreateTestWidget(gfx::Rect(850, 10, 100, 100));
fullscreen->SetFullscreen(true);
@@ -223,8 +222,7 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
maximized->GetNativeView()->GetBoundsInRootWindow().ToString());
EXPECT_EQ(root_windows[0], minimized->GetNativeView()->GetRootWindow());
- EXPECT_EQ("400,20 100x100",
- minimized->GetWindowBoundsInScreen().ToString());
+ EXPECT_TRUE(minimized->GetWindowBoundsInScreen().IsEmpty());
EXPECT_EQ(root_windows[0], fullscreen->GetNativeView()->GetRootWindow());
EXPECT_TRUE(fullscreen->IsFullscreen());
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | ui/aura/window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698