aura: Take transformation into account when computing window bounds in root-window/screen.

ash/root_window_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include "ash/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 135 matching lines @@
   views::Widget* maximized = CreateTestWidget(gfx::Rect(700, 10, 100, 100));
   maximized->Maximize();
   EXPECT_EQ(root_windows[1], maximized->GetNativeView()->GetRootWindow());
   EXPECT_EQ("600,0 300x253", maximized->GetWindowBoundsInScreen().ToString());
   EXPECT_EQ("0,0 300x253",
             maximized->GetNativeView()->GetBoundsInRootWindow().ToString());
 
   views::Widget* minimized = CreateTestWidget(gfx::Rect(800, 10, 100, 100));
   minimized->Minimize();
   EXPECT_EQ(root_windows[1], minimized->GetNativeView()->GetRootWindow());
-  EXPECT_EQ("800,10 100x100",
-            minimized->GetWindowBoundsInScreen().ToString());
+  EXPECT_TRUE(minimized->GetWindowBoundsInScreen().IsEmpty());

[oshima, 2014/02/20 19:39:35]

Do you know why this becomes empty? AFAIK, the minimized window is simply hidden
and doesn't change the bounds or transform.

[sadrul, 2014/02/20 19:59:59]

A transform is applied on he window on minimize, with scale = 0! That causes the
window bounds to be empty (I was pretty surprised when I noticed this).

[oshima, 2014/02/20 20:18:51]

Ah, I think it's coming from minimize animation. Let me double check if we're
keeping that by design or something else.

 
   views::Widget* fullscreen = CreateTestWidget(gfx::Rect(850, 10, 100, 100));
   fullscreen->SetFullscreen(true);
   EXPECT_EQ(root_windows[1], fullscreen->GetNativeView()->GetRootWindow());
 
   EXPECT_EQ("600,0 300x300",
             fullscreen->GetWindowBoundsInScreen().ToString());
   EXPECT_EQ("0,0 300x300",
             fullscreen->GetNativeView()->GetBoundsInRootWindow().ToString());
 
@@ skipping 48 matching lines @@
   // Set fullscreen to true. In that case the 3px inset becomes invisible so
   // the maximized window can also use the area fully.
   fullscreen->SetFullscreen(true);
   EXPECT_EQ(root_windows[0], maximized->GetNativeView()->GetRootWindow());
   EXPECT_EQ("0,0 600x600",
             maximized->GetWindowBoundsInScreen().ToString());
   EXPECT_EQ("0,0 600x600",
             maximized->GetNativeView()->GetBoundsInRootWindow().ToString());
 
   EXPECT_EQ(root_windows[0], minimized->GetNativeView()->GetRootWindow());
-  EXPECT_EQ("400,20 100x100",
-            minimized->GetWindowBoundsInScreen().ToString());
+  EXPECT_TRUE(minimized->GetWindowBoundsInScreen().IsEmpty());
 
   EXPECT_EQ(root_windows[0], fullscreen->GetNativeView()->GetRootWindow());
   EXPECT_TRUE(fullscreen->IsFullscreen());
   EXPECT_EQ("0,0 600x600",
             fullscreen->GetWindowBoundsInScreen().ToString());
   EXPECT_EQ("0,0 600x600",
             fullscreen->GetNativeView()->GetBoundsInRootWindow().ToString());
 
   // Test if the restore bounds are correctly updated.
   wm::GetWindowState(maximized->GetNativeView())->Restore();
@@ skipping 447 matching lines @@
   gfx::Rect after = ash::Shell::GetScreen()->GetPrimaryDisplay().work_area();
   EXPECT_LT(after, before);
 
   // Mock a login user profile change to reinitialize the keyboard.
   ash::Shell::GetInstance()->OnLoginUserProfilePrepared();
   EXPECT_EQ(ash::Shell::GetScreen()->GetPrimaryDisplay().work_area(), before);
 }
 
 }  // namespace test
 }  // namespace ash