Issue 173433002: Do not crash if custom scrollbars have -webkit-appearane:searchfield-foo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173433002: Do not crash if custom scrollbars have -webkit-appearane:searchfield-foo. (Closed)

Created:
6 years, 10 months ago by tkent

Modified:
6 years, 10 months ago

Reviewers:
keishi

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Do not crash if custom scrollbars have -webkit-appearane:searchfield-foo. We need to check nullness of RenderObject::node(). BUG=339200 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167503

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -1 line)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	LayoutTests/scrollbars/custom-scrollbar-appearance-property.html	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderThemeChromiumMac.mm	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderThemeChromiumSkia.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

tkent

Keishi, would you review this please? The test didn't work somehow if dumpAsText() is specified.

6 years, 10 months ago (2014-02-20 03:41:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/173433002/80001

6 years, 10 months ago (2014-02-20 06:59:44 UTC) #4

Message was sent while issue was closed.

Change committed as 167503