Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 17343005: Fix Vtune support to handle deprecation of V8_USE_UNSAFE_HANDLES (Closed)

Created:
7 years, 6 months ago by chunyang.dai
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

In revision 15142, the V8_USE_UNSAFE_HANDLES define is removed. So in the vtune support code ( in vtune-jit.cc file)v8::Handle<T* value> consturctor cannot be invoked directly. We use "->ToString()" to create the Handle<String> object to fix the compilation error. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/third_party/vtune/vtune-jit.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
Please update the subject of the CL to be more appropriate to the change and ...
7 years, 6 months ago (2013-06-24 14:01:47 UTC) #1
chunyang.dai
Hello, Daniel. I updated it. please review it. Thanks.
7 years, 6 months ago (2013-06-24 14:06:18 UTC) #2
danno
lgtm
7 years, 6 months ago (2013-06-24 14:21:07 UTC) #3
danno
7 years, 6 months ago (2013-06-24 14:21:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698