Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1734273003: MIPS64: Fix '[runtime] Optimize and unify rest parameters.'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 Comment cmnt(masm_, "[ new.target"); 260 Comment cmnt(masm_, "[ new.target");
261 SetVar(new_target_var, a3, a0, a2); 261 SetVar(new_target_var, a3, a0, a2);
262 } 262 }
263 263
264 // Possibly allocate RestParameters 264 // Possibly allocate RestParameters
265 int rest_index; 265 int rest_index;
266 Variable* rest_param = scope()->rest_parameter(&rest_index); 266 Variable* rest_param = scope()->rest_parameter(&rest_index);
267 if (rest_param) { 267 if (rest_param) {
268 Comment cmnt(masm_, "[ Allocate rest parameter array"); 268 Comment cmnt(masm_, "[ Allocate rest parameter array");
269 if (!function_in_register_a1) { 269 if (!function_in_register_a1) {
270 __ lw(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 270 __ ld(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
271 } 271 }
272 FastNewRestParameterStub stub(isolate()); 272 FastNewRestParameterStub stub(isolate());
273 __ CallStub(&stub); 273 __ CallStub(&stub);
274 function_in_register_a1 = false; 274 function_in_register_a1 = false;
275 SetVar(rest_param, v0, a1, a2); 275 SetVar(rest_param, v0, a1, a2);
276 } 276 }
277 277
278 Variable* arguments = scope()->arguments(); 278 Variable* arguments = scope()->arguments();
279 if (arguments != NULL) { 279 if (arguments != NULL) {
280 // Function uses arguments object. 280 // Function uses arguments object.
(...skipping 3947 matching lines...) Expand 10 before | Expand all | Expand 10 after
4228 reinterpret_cast<uint64_t>( 4228 reinterpret_cast<uint64_t>(
4229 isolate->builtins()->OsrAfterStackCheck()->entry())); 4229 isolate->builtins()->OsrAfterStackCheck()->entry()));
4230 return OSR_AFTER_STACK_CHECK; 4230 return OSR_AFTER_STACK_CHECK;
4231 } 4231 }
4232 4232
4233 4233
4234 } // namespace internal 4234 } // namespace internal
4235 } // namespace v8 4235 } // namespace v8
4236 4236
4237 #endif // V8_TARGET_ARCH_MIPS64 4237 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698