src/full-codegen/full-codegen.cc - Issue 1734243004: Remove strong mode support from materialized literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1734243004: Remove strong mode support from materialized literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Test expectations. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 3f18219e2c8619c2d4bee7f84949e3e6cb7b7fc8..dc857eea8b57fc075cde5ee8bd47a3cd84e8cec6 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -157,8 +157,7 @@ bool FullCodeGenerator::MustCreateObjectLiteralWithRuntime(

bool FullCodeGenerator::MustCreateArrayLiteralWithRuntime(

ArrayLiteral* expr) const {

- // TODO(rossberg): Teach strong mode to FastCloneShallowArrayStub.

- return expr->depth() > 1 || expr->is_strong() ||

+ return expr->depth() > 1 ||

expr->values()->length() > JSArray::kInitialMaxFastElementArray;

}

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »