Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1734223003:
SkPDF: Let client re-encode JPGs if they want to (Closed)
|
Created:
4 years, 10 months ago by hal.canary Modified:
4 years, 10 months ago Reviewers:
dogben CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkPDF: Let client re-encode JPGs if they want to
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734223003
Committed: https://skia.googlesource.com/skia/+/7363e13a07f8b6a9d4ba82ff7b13526f0a89eaee
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== SkPDF: Let client re-encode JPGs if they want to ========== to ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223003/1
halcanary@google.com changed reviewers: + benjaminwagner@google.com
Your unit test is the only use of this function, now.
lgtm This might cause the roll to fail. If not, then no problem.
On 2016/02/26 at 00:15:29, benjaminwagner wrote: > lgtm > > This might cause the roll to fail. If not, then no problem. I think with the test you have now, nothing changes.
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by halcanary@google.com
Description was changed from ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734223003/1
Description was changed from ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Message was sent while issue was closed.
Description was changed from ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: Let client re-encode JPGs if they want to GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/7363e13a07f8b6a9d4ba82ff7b13526f0a89eaee ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7363e13a07f8b6a9d4ba82ff7b13526f0a89eaee |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
