third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 1734203002: Fully (?) fix overflow: auto with delayed scroll updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 1734203002: Fully (?) fix overflow: auto with delayed scroll updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index 7b8c16b0e2bc488b452652045672baa696817db8..6f95120f85a5207e00a8fa9997b3e9afbb1fae51 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -532,7 +532,7 @@ void LayoutDeprecatedFlexibleBox::layoutHorizontalBox(bool relayoutChildren)

}

} while (haveFlex);

- LayoutBlock::finishDelayUpdateScrollInfo();

+ LayoutBlock::finishDelayUpdateScrollInfo(nullptr);

if (remainingSpace > 0 && ((style()->isLeftToRightDirection() && style()->boxPack() != Start)

|| (!style()->isLeftToRightDirection() && style()->boxPack() != End))) {

@@ -783,7 +783,7 @@ void LayoutDeprecatedFlexibleBox::layoutVerticalBox(bool relayoutChildren)

}

} while (haveFlex);

- LayoutBlock::finishDelayUpdateScrollInfo();

+ LayoutBlock::finishDelayUpdateScrollInfo(nullptr);

if (style()->boxPack() != Start && remainingSpace > 0) {

// Children must be repositioned.