third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 1734203002: Fully (?) fix overflow: auto with delayed scroll updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 1734203002: Fully (?) fix overflow: auto with delayed scroll updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more review comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

index 3a8fb5158e1f88eed429fb435c0b12cdfa029957..db0d5293a4b5920daedef2aa57fe66c93cdd2fb2 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

@@ -253,7 +253,7 @@ public:

scrollToOffset(toDoubleSize(position), ScrollOffsetClamped, scrollBehavior, scrollType);

}

- void updateAfterLayout();

+ bool updateAfterLayout(SubtreeLayoutScope* = nullptr);

skobes 2016/02/25 22:09:31 Can you add a comment here explaining the return v

void updateAfterStyleChange(const ComputedStyle*);

void updateAfterOverflowRecalc();