Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5704)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1734193003: CREDENTIAL: Disable auto sign-in by default for existing credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Yay Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 25cd9ebf2a8e4fc3ca5e2c39a9c9c49a145460ae..c8e52bfaa380c44ef9c671e3f41604f9cca30b36 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -122,7 +122,7 @@ const SecretSchema kLibsecretSchema = {
{"display_name", SECRET_SCHEMA_ATTRIBUTE_STRING},
{"avatar_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
{"federation_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
- {"skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
+ {"should_skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
{"generation_upload_status", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
{"form_data", SECRET_SCHEMA_ATTRIBUTE_STRING},
// This field is always "chrome-profile_id" so that we can search for it.
@@ -195,7 +195,10 @@ scoped_ptr<PasswordForm> FormOutOfAttributes(GHashTable* attrs) {
form->icon_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
form->federation_origin =
url::Origin(GURL(GetStringFromAttributes(attrs, "federation_url")));
- form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");
+ form->skip_zero_click =
+ g_hash_table_lookup(attrs, "should_skip_zero_click")
+ ? GetUintFromAttributes(attrs, "should_skip_zero_click")
+ : true;
form->generation_upload_status =
static_cast<PasswordForm::GenerationUploadStatus>(
GetUintFromAttributes(attrs, "generation_upload_status"));
@@ -476,7 +479,7 @@ bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {
"display_name", UTF16ToUTF8(form.display_name).c_str(),
"avatar_url", form.icon_url.spec().c_str(),
"federation_url", form.federation_origin.Serialize().c_str(),
- "skip_zero_click", form.skip_zero_click,
+ "should_skip_zero_click", form.skip_zero_click,
"generation_upload_status", form.generation_upload_status,
"form_data", form_data.c_str(),
"application", app_string_.c_str(),

Powered by Google App Engine
This is Rietveld 408576698