CREDENTIAL: Disable auto sign-in by default for existing credentials.

chrome/browser/password_manager/native_backend_libsecret.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_libsecret.h"
 
 #include <dlfcn.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 104 matching lines @@
      {"preferred", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"date_created", SECRET_SCHEMA_ATTRIBUTE_STRING},
      {"blacklisted_by_user", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"scheme", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"type", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"times_used", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"date_synced", SECRET_SCHEMA_ATTRIBUTE_STRING},
      {"display_name", SECRET_SCHEMA_ATTRIBUTE_STRING},
      {"avatar_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
      {"federation_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
-     {"skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
+     {"should_skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"generation_upload_status", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
      {"form_data", SECRET_SCHEMA_ATTRIBUTE_STRING},
      // This field is always "chrome-profile_id" so that we can search for it.
      {"application", SECRET_SCHEMA_ATTRIBUTE_STRING},
      {nullptr, SECRET_SCHEMA_ATTRIBUTE_STRING}}};
 
 const char* GetStringFromAttributes(GHashTable* attrs, const char* keyname) {
   gpointer value = g_hash_table_lookup(attrs, keyname);
   return value ? static_cast<char*>(value) : kEmptyString;
 }
@@ skipping 52 matching lines @@
       static_cast<PasswordForm::Scheme>(GetUintFromAttributes(attrs, "scheme"));
   int64_t date_synced = 0;
   base::StringToInt64(GetStringFromAttributes(attrs, "date_synced"),
                       &date_synced);
   form->date_synced = base::Time::FromInternalValue(date_synced);
   form->display_name =
       UTF8ToUTF16(GetStringFromAttributes(attrs, "display_name"));
   form->icon_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
   form->federation_origin =
       url::Origin(GURL(GetStringFromAttributes(attrs, "federation_url")));
-  form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");
+  // Only overwrite the default value of 'skip_zero_click' if we can read a
+  // value from the backend. Otherwise, leave it alone.

[vasilii, 2016/02/26 11:46:31]

Any reason not to assign the member in all the cases?

[Mike West, 2016/02/26 12:29:34]

*shrug* I can add an assignment.

+  if (g_hash_table_lookup(attrs, "should_skip_zero_click")) {
+    form->skip_zero_click = GetUintFromAttributes(attrs,
+                                                  "should_skip_zero_click");
+  }
   form->generation_upload_status =
       static_cast<PasswordForm::GenerationUploadStatus>(
           GetUintFromAttributes(attrs, "generation_upload_status"));
   base::StringPiece encoded_form_data =
       GetStringFromAttributes(attrs, "form_data");
   if (!encoded_form_data.empty()) {
     bool success = DeserializeFormDataFromBase64String(encoded_form_data,
                                                        &form->form_data);
     password_manager::metrics_util::FormDeserializationStatus status =
         success ? password_manager::metrics_util::GNOME_SUCCESS
@@ skipping 260 matching lines @@
       "preferred", form.preferred,
       "date_created", base::Int64ToString(date_created).c_str(),
       "blacklisted_by_user", form.blacklisted_by_user,
       "type", form.type,
       "times_used", form.times_used,
       "scheme", form.scheme,
       "date_synced", base::Int64ToString(date_synced).c_str(),
       "display_name", UTF16ToUTF8(form.display_name).c_str(),
       "avatar_url", form.icon_url.spec().c_str(),
       "federation_url", form.federation_origin.Serialize().c_str(),
-      "skip_zero_click", form.skip_zero_click,
+      "should_skip_zero_click", form.skip_zero_click,
       "generation_upload_status", form.generation_upload_status,
       "form_data", form_data.c_str(),
       "application", app_string_.c_str(),
       nullptr);
   // clang-format on
 
   if (error) {
     LOG(ERROR) << "Libsecret add raw login failed: " << error->message;
     g_error_free(error);
     return false;
@@ skipping 162 matching lines @@
     UMA_HISTOGRAM_ENUMERATION(
         "PasswordManager.PslDomainMatchTriggering",
         password_manager::ShouldPSLDomainMatchingApply(registered_domain)
             ? psl_domain_match_metric
             : password_manager::PSL_DOMAIN_MATCH_NOT_USED,
         password_manager::PSL_DOMAIN_MATCH_COUNT);
   }
   g_list_free(found);
   return forms;
 }