CREDENTIAL: Disable auto sign-in by default for existing credentials.

chrome/browser/password_manager/native_backend_kwallet_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_kwallet_x.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
@@ skipping 19 matching lines @@
 #include "ui/base/l10n/l10n_util.h"
 #include "url/origin.h"
 
 using autofill::PasswordForm;
 using content::BrowserThread;
 
 namespace {
 
 // In case the fields in the pickle ever change, version them so we can try to
 // read old pickles. (Note: do not eat old pickles past the expiration date.)
-const int kPickleVersion = 7;
+const int kPickleVersion = 8;
 
 // We could localize this string, but then changing your locale would cause
 // you to lose access to all your stored passwords. Maybe best not to do that.
 // Name of the folder to store passwords in.
 const char kKWalletFolder[] = "Chrome Form Data";
 
 // DBus service, path, and interface names for klauncher and kwalletd.
 const char kKWalletDName[] = "kwalletd";
 const char kKWalletD5Name[] = "kwalletd5";
 const char kKWalletServiceName[] = "org.kde.kwalletd";
@@ skipping 186 matching lines @@
         LogDeserializationWarning(version, signon_realm, false);
         return false;
       }
       if (read_success) {
         form->generation_upload_status =
             static_cast<PasswordForm::GenerationUploadStatus>(
                 generation_upload_status);
       }
     }
 
+    if (version > 7) {
+      form->skip_zero_click = true;

[vasilii, 2016/02/26 11:46:30]

It's a bug. You read "true" always even if you save "false" later.
You should add something to NativeBackendKWalletPickleTest

[Mike West, 2016/02/26 12:29:34]

Yeah, I misunderstood what was going on here. Added a test.

+    }
+
     converted_forms.push_back(std::move(form));
   }
 
   forms->swap(converted_forms);
   return true;
 }
 
 // Serializes a list of PasswordForms to be stored in the wallet.
 void SerializeValue(const std::vector<autofill::PasswordForm*>& forms,
                     base::Pickle* pickle) {
@@ skipping 814 matching lines @@
   }
 
   return handle;
 }
 
 std::string NativeBackendKWallet::GetProfileSpecificFolderName() const {
   // Originally, the folder name was always just "Chrome Form Data".
   // Now we use it to distinguish passwords for different profiles.
   return base::StringPrintf("%s (%d)", kKWalletFolder, profile_id_);
 }