src/effects/SkLightingImageFilter.cpp - Issue 1734163002: Replace fWillReadFragmentPosition with a bitfield

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 1734163002: Replace fWillReadFragmentPosition with a bitfield (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index 4b0ab8e030d6d16c1d434c68168bff508fa16108..e6fd2377de0c8114d7ed6146207cf3701531b886 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -1657,7 +1657,7 @@ GrLightingEffect::GrLightingEffect(GrTexture* texture,

, fDomain(create_domain(texture, srcBounds, GrTextureDomain::kDecal_Mode)) {

fLight->ref();

if (light->requiresFragmentPosition()) {

- this->setWillReadFragmentPosition();

+ this->enableBuiltInState(kFragmentPosition_BuiltInState);

}