Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 17341011: Use a single cros_toolchain tarball for ChromeOS build (Closed)

Created:
7 years, 6 months ago by borenet
Modified:
7 years, 6 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use a single cros_toolchain tarball for ChromeOS build It's stored in our GS bucket, so we won't need two sets of credentials. BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -32 lines) Patch
M gyp/common.gypi View 2 chunks +2 lines, -4 lines 1 comment Download
M platform_tools/chromeos/bin/chromeos_make View 1 4 chunks +16 lines, -28 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
borenet
https://codereview.chromium.org/17341011/diff/2001/gyp/common.gypi File gyp/common.gypi (left): https://codereview.chromium.org/17341011/diff/2001/gyp/common.gypi#oldcode44 gyp/common.gypi:44: 'error': '<!(skia_cros_target must be defined for ChromeOS)', No longer ...
7 years, 6 months ago (2013-06-21 20:22:32 UTC) #1
djsollen
lgtm https://codereview.chromium.org/17341011/diff/2001/platform_tools/chromeos/bin/chromeos_make File platform_tools/chromeos/bin/chromeos_make (right): https://codereview.chromium.org/17341011/diff/2001/platform_tools/chromeos/bin/chromeos_make#newcode49 platform_tools/chromeos/bin/chromeos_make:49: if ! [[ -d "${CHROMEOS_CHROOT}/.cros_cache" ]]; then is ...
7 years, 6 months ago (2013-06-24 18:46:52 UTC) #2
borenet
https://codereview.chromium.org/17341011/diff/2001/platform_tools/chromeos/bin/chromeos_make File platform_tools/chromeos/bin/chromeos_make (right): https://codereview.chromium.org/17341011/diff/2001/platform_tools/chromeos/bin/chromeos_make#newcode49 platform_tools/chromeos/bin/chromeos_make:49: if ! [[ -d "${CHROMEOS_CHROOT}/.cros_cache" ]]; then On 2013/06/24 ...
7 years, 6 months ago (2013-06-24 18:48:51 UTC) #3
borenet
7 years, 6 months ago (2013-06-24 19:30:58 UTC) #4
Moved to https://codereview.chromium.org/17608003/ since my checkout is
apparently broken.

Powered by Google App Engine
This is Rietveld 408576698