Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: base/metrics/sample_map.h

Issue 1734033003: Add support for persistent sparse histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed more review comments by Alexei Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/sample_map.h
diff --git a/base/metrics/sample_map.h b/base/metrics/sample_map.h
index da536e31e676d1e71516caf5c03c535719168451..4d69dfef876fa43a77593214415e55ccb706d0d0 100644
--- a/base/metrics/sample_map.h
+++ b/base/metrics/sample_map.h
@@ -26,7 +26,7 @@ class BASE_EXPORT SampleMap : public HistogramSamples {
explicit SampleMap(uint64_t id);
~SampleMap() override;
- // HistogramSamples implementation:
+ // HistogramSamples:
void Accumulate(HistogramBase::Sample value,
HistogramBase::Count count) override;
HistogramBase::Count GetCount(HistogramBase::Sample value) const override;
@@ -34,9 +34,8 @@ class BASE_EXPORT SampleMap : public HistogramSamples {
scoped_ptr<SampleCountIterator> Iterator() const override;
protected:
- bool AddSubtractImpl(
- SampleCountIterator* iter,
- HistogramSamples::Operator op) override; // |op| is ADD or SUBTRACT.
+ // Performs arithemetic. |op| is ADD or SUBTRACT.
+ bool AddSubtractImpl(SampleCountIterator* iter, Operator op) override;
private:
std::map<HistogramBase::Sample, HistogramBase::Count> sample_counts_;
@@ -52,7 +51,7 @@ class BASE_EXPORT SampleMapIterator : public SampleCountIterator {
explicit SampleMapIterator(const SampleToCountMap& sample_counts);
~SampleMapIterator() override;
- // SampleCountIterator implementation:
+ // SampleCountIterator:
bool Done() const override;
void Next() override;
void Get(HistogramBase::Sample* min,

Powered by Google App Engine
This is Rietveld 408576698