base/metrics/histogram_unittest.cc - Issue 1734033003: Add support for persistent sparse histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_unittest.cc

Issue 1734033003: Add support for persistent sparse histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed more review comments by Alexei Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_unittest.cc

diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc

index beb6a71ede63c81168a851d099c9afbe8f2918bb..7ef8c8380290806266d6f28cfa2c19e70bcf8a42 100644

--- a/base/metrics/histogram_unittest.cc

+++ b/base/metrics/histogram_unittest.cc

@@ -37,11 +37,12 @@ class HistogramTest : public testing::TestWithParam<bool> {

HistogramTest() : use_persistent_histogram_allocator_(GetParam()) {}

void SetUp() override {

+ if (use_persistent_histogram_allocator_)

+ CreatePersistentMemoryAllocator();

// Each test will have a clean state (no Histogram / BucketRanges

// registered).

InitializeStatisticsRecorder();

- if (use_persistent_histogram_allocator_)

- CreatePersistentMemoryAllocator();

}

void TearDown() override {