Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1733993003: Mv DRRect drawing code from GrDrawContext into SkGpuDevice (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mv DRRect drawing code from GrDrawContext into SkGpuDevice This is a TODO left over from https://codereview.chromium.org/1731413002/ (Hide GrDrawTarget from GrOvalRenderer). It is desireable since the GrDrawContext doesn't, in general, manipulate GrFragmentProcessors. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733993003 Committed: https://skia.googlesource.com/skia/+/d77061067af664a158058771189d152a30acd59a

Patch Set 1 #

Patch Set 2 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -131 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 chunks +0 lines, -109 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 3 chunks +70 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
4 years, 10 months ago (2016-02-25 16:38:31 UTC) #5
joshualitt
On 2016/02/25 16:38:31, robertphillips wrote: beautiful, lgtm
4 years, 10 months ago (2016-02-25 16:43:03 UTC) #6
bsalomon
lgtm
4 years, 10 months ago (2016-02-25 16:59:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733993003/20001
4 years, 10 months ago (2016-02-25 17:05:43 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 17:25:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733993003/20001
4 years, 10 months ago (2016-02-25 17:27:16 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 17:28:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d77061067af664a158058771189d152a30acd59a

Powered by Google App Engine
This is Rietveld 408576698