Issue 173393002: Don't hardcode git directory path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173393002: Don't hardcode git directory path. (Closed)

Created:
6 years, 10 months ago by Michael Moss

Modified:
6 years, 10 months ago

Reviewers:
Dirk Pranke, szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Don't hardcode git directory path. The git path is based on the git version, so it might change whenever git is updated. Run git.bat instead, since that's updated with new git installs and should always point to the right path. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252299

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	fetch.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/173393002/1

6 years, 10 months ago (2014-02-20 17:40:12 UTC) #4

Message was sent while issue was closed.

Change committed as 252299

Expand Messages | Collapse Messages