Issue 17339: Fix for the painting problem with drop down scroll bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17339: Fix for the painting problem with drop down scroll bar (Closed)

Created:
11 years, 11 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes the scroll-bar painting problem in drop-downs. BUG=5084 TEST=Go to a page with a drop-down with many entries (ex: http://www.google.com/advanced_search, the language one). Click the drop-down and scroll. The scroll-bar should paint correctly as you scroll all the way down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7866

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	third_party/WebKit/WebCore/platform/chromium/FramelessScrollView.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/WebCore/platform/chromium/PopupMenuChromium.cpp	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 11 months ago (2009-01-10 17:06:01 UTC) #2

LGTM!

http://codereview.chromium.org/17339/diff/202/204
File third_party/WebKit/WebCore/platform/chromium/PopupMenuChromium.cpp (right):

http://codereview.chromium.org/17339/diff/202/204#newcode662
Line 662: // Since we are returning the HostWindow of our parent as our own in
nit: indent using 4 spaces instead.

Expand Messages | Collapse Messages