Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 17339: Fix for the painting problem with drop down scroll bar (Closed)

Created:
11 years, 11 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes the scroll-bar painting problem in drop-downs. BUG=5084 TEST=Go to a page with a drop-down with many entries (ex: http://www.google.com/advanced_search, the language one). Click the drop-down and scroll. The scroll-bar should paint correctly as you scroll all the way down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7866

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/WebCore/platform/chromium/FramelessScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/platform/chromium/PopupMenuChromium.cpp View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 11 months ago (2009-01-10 00:38:00 UTC) #1
darin (slow to review)
11 years, 11 months ago (2009-01-10 17:06:01 UTC) #2
LGTM!

http://codereview.chromium.org/17339/diff/202/204
File third_party/WebKit/WebCore/platform/chromium/PopupMenuChromium.cpp (right):

http://codereview.chromium.org/17339/diff/202/204#newcode662
Line 662: // Since we are returning the HostWindow of our parent as our own in
nit: indent using 4 spaces instead.

Powered by Google App Engine
This is Rietveld 408576698