Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 1733893003: Reland of md5check'ify lint.py (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: md5check'ify lint.py When locally building chrome_public_apk_incremental and making a non-public change to a content_java file, this brings ninja time: 24s -> 7s BUG=None TBR=jbudorick Committed: https://crrev.com/db14f77f9542e237ce08166d587a5b7d948d091c Cr-Commit-Position: refs/heads/master@{#377758}

Patch Set 1 #

Patch Set 2 : Don't trim source list when resources are present. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -23 lines) Patch
M build/android/gyp/lint.py View 1 7 chunks +40 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
Created Reland of md5check'ify lint.py
4 years, 10 months ago (2016-02-25 19:57:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733893003/40001
4 years, 10 months ago (2016-02-25 20:03:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 21:27:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733893003/40001
4 years, 10 months ago (2016-02-26 01:19:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-26 01:31:54 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 01:34:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db14f77f9542e237ce08166d587a5b7d948d091c
Cr-Commit-Position: refs/heads/master@{#377758}

Powered by Google App Engine
This is Rietveld 408576698