Fix bug in SkGifCodec / Switch SkImageDec tests to use Codec

tests/BadIcoTest.cpp

Index: tests/BadIcoTest.cpp
diff --git a/tests/BadIcoTest.cpp b/tests/BadIcoTest.cpp
deleted file mode 100644
index 240de514c981f2881d9ee356813fe2d4f760e87d..0000000000000000000000000000000000000000
--- a/tests/BadIcoTest.cpp
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Copyright 2014 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#include "Resources.h"
-#include "Test.h"
-#include "SkBitmap.h"
-#include "SkImageDecoder.h"
-#include "SkOSFile.h"
-
-DEF_TEST(BadImage, reporter) {
-    const char* const badImages [] = {
-        "sigabort_favicon.ico",
-        "sigsegv_favicon.ico",
-        "sigsegv_favicon_2.ico",
-        "ico_leak01.ico",
-        "ico_fuzz0.ico",
-        "ico_fuzz1.ico",
-        "skbug3442.webp",
-        "skbug3429.webp",
-    };
-
-    const char* badImagesFolder = "invalid_images";
-
-    SkString resourcePath = GetResourcePath(badImagesFolder);
-
-    SkBitmap bm;
-    for (size_t i = 0; i < SK_ARRAY_COUNT(badImages); ++i) {
-        SkString fullPath = SkOSPath::Join(resourcePath.c_str(), badImages[i]);
-        bool success = SkImageDecoder::DecodeFile(fullPath.c_str(), &bm);

[scroggo, 2016/02/25 12:43:29]

Why not switch this to use SkCodec?

[msarett, 2016/03/01 00:21:11]

Done.

-        // These files are invalid, and should not decode. More importantly,
-        // though, we reached here without crashing.
-        REPORTER_ASSERT(reporter, !success);
-    }
-}