Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1733863002: OS::ArmUsingHardFloat returns bogus value for clang-built chrome. (Closed)

Created:
4 years, 10 months ago by Han
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

OS::ArmUsingHardFloat returns bogus value for clang-built chrome. This caused a runtime crash for Chrome built with clang on all ChromeOs arm32 platforms - ChromeOs chrome is using hardfp while this routine returns false. The fix is straightforward. BUG=chromium:586219 TEST=built arm32 hardfp using clang and passed all tests. LOG=N Committed: https://crrev.com/2b29b63031fd2038747e7bfea818d77870500379 Cr-Commit-Position: refs/heads/master@{#34367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/platform/platform-linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Han
4 years, 10 months ago (2016-02-26 23:15:52 UTC) #3
Yang
lgtm.
4 years, 9 months ago (2016-02-29 12:38:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733863002/1
4 years, 9 months ago (2016-02-29 18:13:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 18:30:05 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 18:30:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b29b63031fd2038747e7bfea818d77870500379
Cr-Commit-Position: refs/heads/master@{#34367}

Powered by Google App Engine
This is Rietveld 408576698