Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1733853002: IDL for index. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : We store only URI strings. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+585 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 2 chunks +470 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 4 chunks +115 lines, -0 lines 4 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-24 23:19:49 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1733853002/diff/20001/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/1733853002/diff/20001/pkg/analyzer/lib/src/summary/idl.dart#newcode140 pkg/analyzer/lib/src/summary/idl.dart:140: * TODO(scheglov) document Please document this. https://codereview.chromium.org/1733853002/diff/20001/pkg/analyzer/lib/src/summary/idl.dart#newcode177 pkg/analyzer/lib/src/summary/idl.dart:177: ...
4 years, 10 months ago (2016-02-25 17:14:25 UTC) #2
scheglov
4 years, 10 months ago (2016-02-25 17:40:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
160b72126297ab08e1b34bddb5c2b828bbc87116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698