Add tests for indexing.

Add tests for indexing.

No tests yet for multi-level constructor redirection and
qualified/unqualified references.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c106ad40331ae70acda02e8fdbd088f772e17524

[Paul Berry, 2016-02-26 19:02:05]

lgtm

https://codereview.chromium.org/1733843007/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1733843007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:138: * The element itself.
I'm confused.  How can the "kind" of an element be the element itself?  What is
this used for?

https://codereview.chromium.org/1733843007/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1733843007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:142: if (element is
ConstructorElement && element.isSynthetic) {
Why are only synthetic constructors classified as IndexElementKind.constructor?

If this is really what we want, consider renaming IndexElementKind.constructor
to IndexElementKind.syntheticConstructor and IndexElementKind.element to
IndexElementKind.other so that the expectation is clear.

https://codereview.chromium.org/1733843007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:173: static const int KIND_ELEMENT
= 0;
I don't see where these are used, and I'm concerned that they duplicate the
functionality of IndexElementKind.

[scheglov, 2016-02-26 19:19:04]

Description was changed from

==========
Add tests for indexing.

No tests yet for multi-level constructor redirection and
qualified/unqualified references.

R=paulberry@google.com
BUG=
==========

to

==========
Add tests for indexing.

No tests yet for multi-level constructor redirection and
qualified/unqualified references.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c106ad40331ae70acda02e8fdbd088f772e17524
==========

[scheglov, 2016-02-26 19:19:06]

Committed patchset #1 (id:1) manually as
c106ad40331ae70acda02e8fdbd088f772e17524 (presubmit successful).