Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1733843002: Use kSubpixelRounding in one missed location. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use kSubpixelRounding in one missed location. The kSubpixelRounding macro was created to clarify a block of code, but one simplification was missed. Committed: https://skia.googlesource.com/skia/+/fa5e5c75218a877d30177d08686d8ec0ea050b0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkFindAndPlaceGlyph.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
bungeman-skia
4 years, 10 months ago (2016-02-24 22:21:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733843002/1
4 years, 10 months ago (2016-02-24 22:21:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 23:25:55 UTC) #8
herb_g
lgtm
4 years, 10 months ago (2016-02-25 04:48:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733843002/1
4 years, 10 months ago (2016-02-25 15:06:48 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 15:07:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa5e5c75218a877d30177d08686d8ec0ea050b0a

Powered by Google App Engine
This is Rietveld 408576698