Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1733693002: Remove xfa_common.h and IWYU. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -55 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffConfigAcc.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffapp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffbarcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffcheckbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdochandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffexclgroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimageedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsignature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsubform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgethandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_rendercontext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_textlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/src/fxfa/src/common/xfa_common.h View 1 chunk +0 lines, -22 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_parser.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-24 16:38:27 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-24 18:20:41 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-24 18:26:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4b337799480c64e8db5b2bc50cea876d3789b989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698