Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1733663003: PPC: [compiler] Drop the CompareNilIC. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Drop the CompareNilIC. Port 666aec0348c8793e61c8633dee7ad29a514239ba Original commit message: Since both null and undefined are also marked as undetectable now, we can just test that bit instead of having the CompareNilIC try to collect feedback to speed up the general case (without the undetectable bit being used). Drive-by-fix: Update the type system to match the new handling of undetectable in the runtime. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/546ea6b8393a894f07597ade5ec1c7db02c1e425 Cr-Commit-Position: refs/heads/master@{#34266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-24 18:43:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733663003/1
4 years, 10 months ago (2016-02-24 18:56:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 19:15:26 UTC) #5
JoranSiu
On 2016/02/24 19:15:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-24 22:23:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733663003/1
4 years, 10 months ago (2016-02-24 22:30:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 22:32:02 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/546ea6b8393a894f07597ade5ec1c7db02c1e425 Cr-Commit-Position: refs/heads/master@{#34266}
4 years, 10 months ago (2016-02-24 22:32:41 UTC) #11
MTBrandyberry
4 years, 10 months ago (2016-02-26 21:24:43 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1736253003/ by mbrandy@us.ibm.com.

The reason for reverting is: Original commit reverted..

Powered by Google App Engine
This is Rietveld 408576698