Chromium Code Reviews| Index: Source/modules/mediastream/UserMediaRequest.h |
| diff --git a/Source/modules/mediastream/UserMediaRequest.h b/Source/modules/mediastream/UserMediaRequest.h |
| index 9f98b416c56f7b87d5fdae93da51554eeadad9bd..dd6c4db72bad5250354d78e0773b3608f539fecd 100644 |
| --- a/Source/modules/mediastream/UserMediaRequest.h |
| +++ b/Source/modules/mediastream/UserMediaRequest.h |
| @@ -48,9 +48,10 @@ class ExceptionState; |
| class MediaStreamDescriptor; |
| class UserMediaController; |
| -class UserMediaRequest FINAL : public RefCounted<UserMediaRequest>, public ContextLifecycleObserver { |
| +class UserMediaRequest FINAL : public RefCountedWillBeGarbageCollected<UserMediaRequest>, public ContextLifecycleObserver { |
|
sof
2014/02/20 15:30:23
I think the observer needs finalization (cf Lifecy
keishi
2014/02/21 08:00:25
Done.
|
| + DECLARE_GC_INFO; |
| public: |
| - static PassRefPtr<UserMediaRequest> create(ExecutionContext*, UserMediaController*, const Dictionary& options, PassOwnPtr<NavigatorUserMediaSuccessCallback>, PassOwnPtr<NavigatorUserMediaErrorCallback>, ExceptionState&); |
| + static PassRefPtrWillBeRawPtr<UserMediaRequest> create(ExecutionContext*, UserMediaController*, const Dictionary& options, PassOwnPtr<NavigatorUserMediaSuccessCallback>, PassOwnPtr<NavigatorUserMediaErrorCallback>, ExceptionState&); |
| virtual ~UserMediaRequest(); |
| NavigatorUserMediaSuccessCallback* successCallback() const { return m_successCallback.get(); } |
| @@ -71,6 +72,8 @@ public: |
| // ContextLifecycleObserver |
| virtual void contextDestroyed() OVERRIDE; |
| + void trace(Visitor*) { } |
| + |
| private: |
| UserMediaRequest(ExecutionContext*, UserMediaController*, blink::WebMediaConstraints audio, blink::WebMediaConstraints video, PassOwnPtr<NavigatorUserMediaSuccessCallback>, PassOwnPtr<NavigatorUserMediaErrorCallback>); |