Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2052)

Unified Diff: Source/modules/mediastream/MediaDeviceInfo.h

Issue 173363002: Move mediastream module to oilpan transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: toRefPtrWillBeMemberNativeArray Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/MediaDeviceInfo.h
diff --git a/Source/modules/mediastream/MediaDeviceInfo.h b/Source/modules/mediastream/MediaDeviceInfo.h
index 36546208886c6071e8369def3b46bc0ab96a6240..e136116d74c7910ce12ff77ebb1589fa10f2325b 100644
--- a/Source/modules/mediastream/MediaDeviceInfo.h
+++ b/Source/modules/mediastream/MediaDeviceInfo.h
@@ -26,6 +26,7 @@
#ifndef MediaDeviceInfo_h
#define MediaDeviceInfo_h
+#include "platform/heap/Handle.h"
#include "public/platform/WebMediaDeviceInfo.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -33,22 +34,24 @@
namespace WebCore {
-class MediaDeviceInfo : public RefCounted<MediaDeviceInfo> {
+class MediaDeviceInfo : public RefCountedWillBeGarbageCollectedFinalized<MediaDeviceInfo> {
sof 2014/04/07 14:22:16 Add FINAL?
haraken 2014/04/08 04:42:35 Can this be RefCountedWillBeGarbageCollected ?
keishi 2014/04/11 20:03:06 Done.
keishi 2014/04/11 20:03:06 gc plugin gives an error. ../../third_party/WebKi
public:
- static PassRefPtr<MediaDeviceInfo> create(const blink::WebMediaDeviceInfo&);
+ static PassRefPtrWillBeRawPtr<MediaDeviceInfo> create(const blink::WebMediaDeviceInfo&);
String deviceId() const;
String kind() const;
String label() const;
String groupId() const;
+ void trace(Visitor*) { }
+
private:
explicit MediaDeviceInfo(const blink::WebMediaDeviceInfo&);
blink::WebMediaDeviceInfo m_webMediaDeviceInfo;
};
-typedef Vector<RefPtr<MediaDeviceInfo> > MediaDeviceInfoVector;
+typedef WillBeHeapVector<RefPtrWillBeMember<MediaDeviceInfo> > MediaDeviceInfoVector;
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698