Source/bindings/scripts/v8_types.py - Issue 173363002: Move mediastream module to oilpan transition types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 173363002: Move mediastream module to oilpan transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: toRefPtrWillBeMemberNativeArray Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index e5d9a09e402a80733d8bd6e2c522caad4a8ec9ba..4f4157dee5107161b876b5d07eec7d4699fc62da 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -388,7 +388,7 @@ def v8_value_to_cpp_value_array_or_sequence(array_or_sequence_type, v8_value, in

if (array_or_sequence_type.is_interface_type and

array_or_sequence_type.name != 'Dictionary'):

this_cpp_type = None

- ref_ptr_type = 'Member' if array_or_sequence_type.is_will_be_garbage_collected else 'RefPtr'

+ ref_ptr_type = 'RefPtrWillBeMember' if array_or_sequence_type.is_will_be_garbage_collected else 'RefPtr'

expression_format = '(to{ref_ptr_type}NativeArray<{array_or_sequence_type}, V8{array_or_sequence_type}>({v8_value}, {index}, info.GetIsolate()))'

add_includes_for_type(array_or_sequence_type)

else: