Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: Source/modules/mediastream/RTCStatsResponse.h

Issue 173363002: Move mediastream module to oilpan transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: WIP Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCStatsResponse.h
diff --git a/Source/modules/mediastream/RTCStatsResponse.h b/Source/modules/mediastream/RTCStatsResponse.h
index 9bda7feefca2995cad718f46e6cebbebada3bc32..181c64dbfe243aa99bec5c84b28ea2289db6f69c 100644
--- a/Source/modules/mediastream/RTCStatsResponse.h
+++ b/Source/modules/mediastream/RTCStatsResponse.h
@@ -26,6 +26,7 @@
#define RTCStatsResponse_h
#include "bindings/v8/ScriptWrappable.h"
+#include "heap/Handle.h"
#include "modules/mediastream/RTCStatsReport.h"
#include "platform/mediastream/RTCStatsResponseBase.h"
#include "wtf/HashMap.h"
@@ -38,16 +39,16 @@ class RTCStatsResponse FINAL : public RTCStatsResponseBase, public ScriptWrappab
public:
static PassRefPtr<RTCStatsResponse> create();
- const Vector<RefPtr<RTCStatsReport> >& result() const { return m_result; }
+ const WillBePersistentHeapVector<RefPtrWillBeMember<RTCStatsReport> >& result() const { return m_result; }
haraken 2014/02/26 13:58:37 We should return WillBeHeapVector<RefPtrWillBeMemb
haraken 2014/02/26 13:58:37 Another way to fix this would be just to move RTCS
keishi 2014/02/27 07:33:34 Done.
- PassRefPtr<RTCStatsReport> namedItem(const AtomicString& name);
+ PassRefPtrWillBeRawPtr<RTCStatsReport> namedItem(const AtomicString& name);
virtual size_t addReport(String id, String type, double timestamp) OVERRIDE;
virtual void addStatistic(size_t report, String name, String value) OVERRIDE;
private:
RTCStatsResponse();
- Vector<RefPtr<RTCStatsReport> > m_result;
+ WillBePersistentHeapVector<RefPtrWillBeMember<RTCStatsReport> > m_result;
HashMap<String, int> m_idmap;
};

Powered by Google App Engine
This is Rietveld 408576698