Move mediastream module to oilpan transition types

Source/modules/mediastream/MediaStreamTrack.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2011 Ericsson AB. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 27 matching lines @@
 #include "wtf/Vector.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
 class AudioSourceProvider;
 class ExceptionState;
 class MediaStreamComponent;
 class MediaStreamTrackSourcesCallback;
 
-class MediaStreamTrack FINAL : public RefCounted<MediaStreamTrack>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData, public MediaStreamSource::Observer {
-    REFCOUNTED_EVENT_TARGET(MediaStreamTrack);
+class MediaStreamTrack FINAL : public RefCountedWillBeRefCountedGarbageCollected<MediaStreamTrack>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData, public MediaStreamSource::Observer {
+    DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedWillBeRefCountedGarbageCollected<MediaStreamTrack>);
 public:
     class Observer {
     public:
         virtual ~Observer() { }
         virtual void trackEnded() = 0;
     };
 
-    static PassRefPtr<MediaStreamTrack> create(ExecutionContext*, MediaStreamComponent*);
+    static PassRefPtrWillBeRawPtr<MediaStreamTrack> create(ExecutionContext*, MediaStreamComponent*);
     virtual ~MediaStreamTrack();
 
     String kind() const;
     String id() const;
     String label() const;
 
     bool enabled() const;
     void setEnabled(bool);
 
     String readyState() const;
 
     static void getSources(ExecutionContext*, PassOwnPtr<MediaStreamTrackSourcesCallback>, ExceptionState&);
     void stopTrack(ExceptionState&);
-    PassRefPtr<MediaStreamTrack> clone(ExecutionContext*);
+    PassRefPtrWillBeRawPtr<MediaStreamTrack> clone(ExecutionContext*);
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(mute);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(unmute);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(ended);
 
     MediaStreamComponent* component();
     bool ended() const;
 
     void addObserver(Observer*);
     void removeObserver(Observer*);
 
     // EventTarget
     virtual const AtomicString& interfaceName() const OVERRIDE;
     virtual ExecutionContext* executionContext() const OVERRIDE;
 
     // ActiveDOMObject
     virtual void stop() OVERRIDE;
 
     PassOwnPtr<AudioSourceProvider> createWebAudioSource();
 
+    void trace(Visitor*) { }
+
 private:
     MediaStreamTrack(ExecutionContext*, MediaStreamComponent*);
 
     MediaStreamSource::ReadyState m_readyState;
 
     // MediaStreamSourceObserver
     virtual void sourceChangedState() OVERRIDE;
 
     void propagateTrackEnded();
     Vector<Observer*> m_observers;

[haraken, 2014/04/08 04:42:35]

As I commented in MediaStream.h, this should be a vector of weak members.

[keishi, 2014/04/11 20:03:06]

I had trouble making MediaStreamTrack::Observer garbage collected so I changed
this to a vector of MediaStreams. I was getting errors like:
 ../../third_party/WebKit/Source/modules/mediastream/MediaStream.cpp:63:53:
error: member 'operator new' found in multiple base classes of different types
    return adoptRefWillBeRefCountedGarbageCollected(new MediaStream(context,
audioTracks, videoTracks));

[haraken, 2014/04/14 04:42:43]

Sounds reasonable!

     bool m_isIteratingObservers;
 
     bool m_stopped;
     RefPtr<MediaStreamComponent> m_component;
 };
 
-typedef Vector<RefPtr<MediaStreamTrack> > MediaStreamTrackVector;
+typedef WillBeHeapVector<RefPtrWillBeMember<MediaStreamTrack> > MediaStreamTrackVector;
 
 } // namespace WebCore
 
 #endif // MediaStreamTrack_h