Move mediastream module to oilpan transition types

Source/bindings/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 482 matching lines @@
             } else {
                 if (success)
                     *success = false;
                 throwTypeError("Invalid Array element type", isolate);
                 return Vector<RefPtr<T> >();
             }
         }
         return result;
     }
 
+    template <class T, class V8T>
+    WillBeHeapVector<RefPtrWillBeMember<T> > toRefPtrWillBeMemberNativeArrayUnchecked(v8::Local<v8::Value> v8Value, uint32_t length, v8::Isolate* isolate, bool* success = 0)

[haraken, 2014/02/21 10:47:05]

Instead of adding a method for WillBeHeapVector<RefPtrWillBeMember>, you should
add a method for HeapVector<Member>. (I wonder why this CL compiles when the
OILPAN flag is disabled, since we will end up having two identical methods for
Vector<RefPtr> when the OILPAN flag is disabled.)

The point is that we need methods for both Vector<RefPtr> (which we already
have) and HeapVector<Member> (which we need in this CL).

[keishi, 2014/02/26 06:14:59]

If I prepare two versions of toRefPtrNativeArray() I get the error:
error: call to 'toRefPtrNativeArray' is ambiguous

CL https://codereview.chromium.org/178363010

+    {
+        WillBeHeapVector<RefPtrWillBeMember<T> > result;
+        result.reserveInitialCapacity(length);
+        v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(v8Value);
+        for (uint32_t i = 0; i < length; ++i) {
+            v8::Handle<v8::Value> element = object->Get(i);
+
+            if (V8T::hasInstance(element, isolate)) {
+                v8::Handle<v8::Object> elementObject = v8::Handle<v8::Object>::Cast(element);
+                result.uncheckedAppend(V8T::toNative(elementObject));
+            } else {
+                if (success)
+                    *success = false;
+                throwTypeError("Invalid Array element type", isolate);
+                return WillBeHeapVector<RefPtrWillBeMember<T> >();
+            }
+        }
+        return result;
+    }
+
     v8::Handle<v8::Value> toV8Sequence(v8::Handle<v8::Value>, uint32_t& length, v8::Isolate*);
 
     template <class T, class V8T>
     Vector<RefPtr<T> > toRefPtrNativeArray(v8::Handle<v8::Value> value, int argumentIndex, v8::Isolate* isolate, bool* success = 0)
     {
         if (success)
             *success = true;
 
         v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));
         uint32_t length = 0;
         if (value->IsArray()) {
             length = v8::Local<v8::Array>::Cast(v8Value)->Length();
         } else if (toV8Sequence(value, length, isolate).IsEmpty()) {
             throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex), isolate);
             return Vector<RefPtr<T> >();
         }
 
         return toRefPtrNativeArrayUnchecked<T, V8T>(v8Value, length, isolate, success);
     }
 
     template <class T, class V8T>
+    WillBeHeapVector<RefPtrWillBeMember<T> > toRefPtrWillBeMemberNativeArray(v8::Handle<v8::Value> value, int argumentIndex, v8::Isolate* isolate, bool* success = 0)

[haraken, 2014/02/21 10:47:05]

Ditto. You can add a method for HeapVector<Member>.

+    {
+        if (success)
+            *success = true;
+
+        v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));
+        uint32_t length = 0;
+        if (value->IsArray()) {
+            length = v8::Local<v8::Array>::Cast(v8Value)->Length();
+        } else if (toV8Sequence(value, length, isolate).IsEmpty()) {
+            throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex), isolate);
+            return WillBeHeapVector<RefPtrWillBeMember<T> >();
+        }
+
+        return toRefPtrWillBeMemberNativeArrayUnchecked<T, V8T>(v8Value, length, isolate, success);
+    }
+
+    template <class T, class V8T>
     Vector<RefPtr<T> > toRefPtrNativeArray(v8::Handle<v8::Value> value, const String& propertyName, v8::Isolate* isolate, bool* success = 0)
     {
         if (success)
             *success = true;
 
         v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));
         uint32_t length = 0;
         if (value->IsArray()) {
             length = v8::Local<v8::Array>::Cast(v8Value)->Length();
         } else if (toV8Sequence(value, length, isolate).IsEmpty()) {
@@ skipping 181 matching lines @@
             m_isolate->ClearInterrupt();
         }
 
     private:
         v8::Isolate* m_isolate;
     };
 
 } // namespace WebCore
 
 #endif // V8Binding_h