Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: test/cctest/test-log.cc

Issue 17336003: remove all old style callbacks - patch 3 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index 5daf8dd53feeaf44f3f4ea1548c878ae61cdabe1..8615784fb6f17e0b44149adce2a360402064e7f0 100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -392,8 +392,7 @@ TEST(Issue23768) {
}
-static v8::Handle<v8::Value> ObjMethod1(const v8::Arguments& args) {
- return v8::Handle<v8::Value>();
+static void ObjMethod1(const v8::FunctionCallbackInfo<v8::Value>& args) {
}
TEST(LogCallbacks) {
@@ -431,19 +430,17 @@ TEST(LogCallbacks) {
}
-static v8::Handle<v8::Value> Prop1Getter(v8::Local<v8::String> property,
- const v8::AccessorInfo& info) {
- return v8::Handle<v8::Value>();
+static void Prop1Getter(v8::Local<v8::String> property,
+ const v8::PropertyCallbackInfo<v8::Value>& info) {
}
static void Prop1Setter(v8::Local<v8::String> property,
- v8::Local<v8::Value> value,
- const v8::AccessorInfo& info) {
+ v8::Local<v8::Value> value,
+ const v8::PropertyCallbackInfo<void>& info) {
}
-static v8::Handle<v8::Value> Prop2Getter(v8::Local<v8::String> property,
- const v8::AccessorInfo& info) {
- return v8::Handle<v8::Value>();
+static void Prop2Getter(v8::Local<v8::String> property,
+ const v8::PropertyCallbackInfo<v8::Value>& info) {
}
TEST(LogAccessorCallbacks) {
« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698