Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 17335003: Introduce Type::Intersect function (Closed)

Created:
7 years, 6 months ago by rossberg
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev, danno
Visibility:
Public.

Description

Introduce Type::Intersect function Also, fix bugs in Type::Union and Type::Maybe. (This subsumes the in-flight fix for Union in https://codereview.chromium.org/16925008/, including test cases). R=svenpanne@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15224

Patch Set 1 #

Patch Set 2 : Tweak comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -87 lines) Patch
M src/types.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/types.cc View 1 5 chunks +84 lines, -9 lines 0 comments Download
M test/cctest/test-types.cc View 11 chunks +243 lines, -78 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 6 months ago (2013-06-19 12:45:31 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-20 08:14:04 UTC) #2
rossberg
7 years, 6 months ago (2013-06-20 09:10:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698