Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(327)

Issue 173347: Proactively rebaselined ruby pixel layout tests (Closed)

Created:
9 years, 10 months ago by Roland
Modified:
8 years, 1 month ago
Reviewers:
eroman, sky, dglazkov, hamaji
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Rebaselined pixel tests for the upcoming ruby rendering implementation (https://bugs.webkit.org/show_bug.cgi?id=28420). Note that at the time of posting these rebaselined versions, the originals have not yet landed, but I don't expect them to change anymore (submitting early to save time). BUG=20206 TEST=layout tests under 'fast/ruby'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+685 lines, -0 lines) Patch
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.txt View 1 chunk +74 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.txt View 1 chunk +48 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland
Proactively rebaselined versions of the pixel layout tests for ruby rendering. Note: Originals haven't landed ...
9 years, 10 months ago (2009-08-25 12:42:15 UTC) #1
eroman
Sorry for not responding earlier (was on vacation). I think it only makes sense to ...
9 years, 9 months ago (2009-09-01 07:23:23 UTC) #2
dglazkov
9 years, 7 months ago (2009-11-05 00:02:05 UTC) #3
Hamaji and I collaborated to make your morning a bit easier :)

http://codereview.chromium.org/173347

Powered by Google App Engine
This is Rietveld 408576698