Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1733463005: Domain Reliability: Add more Gmail domains (Closed)

Created:
4 years, 10 months ago by Deprecated (see juliatuttle)
Modified:
4 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Add more Gmail domains BUG= Committed: https://crrev.com/6fb41398844159d23b37ab41382d950c75cb5ac6 Cr-Commit-Position: refs/heads/master@{#378033}

Patch Set 1 #

Patch Set 2 : Depend on baked_in_configs.gypi so removing configs works. #

Patch Set 3 : rebase? :| #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M components/domain_reliability.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/domain_reliability/baked_in_configs.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D components/domain_reliability/baked_in_configs/mail_google_com.json View 1 chunk +0 lines, -20 lines 1 comment Download
M components/domain_reliability/google_configs.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463005/1
4 years, 10 months ago (2016-02-25 15:06:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/173567)
4 years, 10 months ago (2016-02-25 15:48:19 UTC) #4
Deprecated (see juliatuttle)
PTAL, davidben.
4 years, 10 months ago (2016-02-25 20:42:00 UTC) #6
davidben
(Try bots seem to be exploding for some reason.)
4 years, 10 months ago (2016-02-25 21:16:25 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463005/40001
4 years, 10 months ago (2016-02-26 18:40:28 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 20:18:08 UTC) #11
Deprecated (see juliatuttle)
PTAL, davidben.
4 years, 10 months ago (2016-02-26 21:08:36 UTC) #12
davidben
lgtm https://codereview.chromium.org/1733463005/diff/40001/components/domain_reliability/baked_in_configs/mail_google_com.json File components/domain_reliability/baked_in_configs/mail_google_com.json (left): https://codereview.chromium.org/1733463005/diff/40001/components/domain_reliability/baked_in_configs/mail_google_com.json#oldcode17 components/domain_reliability/baked_in_configs/mail_google_com.json:17: "/*/channel/bind", I am assuming it is okay that ...
4 years, 10 months ago (2016-02-26 21:13:33 UTC) #13
Deprecated (see juliatuttle)
On 2016/02/26 21:13:33, davidben wrote: > lgtm > > https://codereview.chromium.org/1733463005/diff/40001/components/domain_reliability/baked_in_configs/mail_google_com.json > File components/domain_reliability/baked_in_configs/mail_google_com.json (left): > ...
4 years, 10 months ago (2016-02-26 21:15:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463005/40001
4 years, 10 months ago (2016-02-26 21:18:34 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-27 00:12:17 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 00:14:00 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6fb41398844159d23b37ab41382d950c75cb5ac6
Cr-Commit-Position: refs/heads/master@{#378033}

Powered by Google App Engine
This is Rietveld 408576698