Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1733463004: PlzNavigate: notify a WebUI of RVH creation when it is commited at creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index df798cfc97d3f34cde8b27183a7adcb62aaf2eb2..8076ef473447455a57d803c5873adaab7892955f 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -885,6 +885,15 @@ RenderFrameHostImpl* RenderFrameHostManager::GetFrameHostForNavigation(
// (Note that we don't care about on{before}unload handlers if the current
// RFH isn't live.)
CommitPending();
+
+ // Notify the WebUI of the creation of the RenderView if needed (the
+ // newly created WebUI has just been committed by CommitPending, so
+ // GetNavigatingWebUI() below will return false).
+ if (notify_webui_of_rv_creation && render_frame_host_->web_ui()) {
+ render_frame_host_->web_ui()->RenderViewCreated(
+ render_frame_host_->render_view_host());
+ notify_webui_of_rv_creation = false;
+ }
}
}
DCHECK(navigation_rfh &&
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698