Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1733463004:
PlzNavigate: notify a WebUI of RVH creation when it is commited at creation (Closed)
|
Created:
4 years, 10 months ago by clamy Modified:
4 years, 9 months ago Reviewers:
nasko CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPlzNavigate: notify a WebUI of RVH creation when it is commited at creation
This CL makes it so that a newly created WebUI is notified that a
RenderViewHost was created for it when it is committed immediately after being
created (when the current RenderFrameHost is not live). This was not previously
the case, as the code tried to get the navigating WebUI, defined as the WebUI
of the speculative RenderFrameHost or the pending WebUI of the current
RenderFrameHost. In the case where the speculative RenderFrameHost is created,
the new WebUI becomes the current WebUI of the current RenderFrameHost, and
GetNavigatingWebUI() returns nullptr.
BUG=475027
Committed: https://crrev.com/3b14d074ebf91788a01ee3b0544b66e1f65f1bca
Cr-Commit-Position: refs/heads/master@{#378430}
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
Description was changed from ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 ========== to ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
clamy@chromium.org changed reviewers: + nasko@chromium.org
@nasko: PTAL
LGTM
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by clamy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
The CQ bit was checked by clamy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
The CQ bit was checked by clamy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
Description was changed from ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 ==========
The CQ bit was checked by clamy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733463004/1
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 ========== to ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 ========== to ========== PlzNavigate: notify a WebUI of RVH creation when it is commited at creation This CL makes it so that a newly created WebUI is notified that a RenderViewHost was created for it when it is committed immediately after being created (when the current RenderFrameHost is not live). This was not previously the case, as the code tried to get the navigating WebUI, defined as the WebUI of the speculative RenderFrameHost or the pending WebUI of the current RenderFrameHost. In the case where the speculative RenderFrameHost is created, the new WebUI becomes the current WebUI of the current RenderFrameHost, and GetNavigatingWebUI() returns nullptr. BUG=475027 Committed: https://crrev.com/3b14d074ebf91788a01ee3b0544b66e1f65f1bca Cr-Commit-Position: refs/heads/master@{#378430} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3b14d074ebf91788a01ee3b0544b66e1f65f1bca Cr-Commit-Position: refs/heads/master@{#378430}
Message was sent while issue was closed.
Nice catch on this one! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
