Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1733363002: [interpreter] Enable tests on x64-debug that no longer fail. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Enable tests on x64-debug that no longer fail. R=rmcilroy@chromium.org Committed: https://crrev.com/bbd60c5d7166c62b8540382f857ba6de185228b7 Cr-Commit-Position: refs/heads/master@{#34299}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M test/cctest/cctest.status View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Starzinger
Cannot repro locally. Let's see what try-bots have to say.
4 years, 10 months ago (2016-02-25 15:33:12 UTC) #1
rmcilroy
LGTM if all are happy.
4 years, 10 months ago (2016-02-25 15:49:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733363002/1
4 years, 10 months ago (2016-02-25 16:07:56 UTC) #4
commit-bot: I haz the power
Failed to apply patch for test/cctest/cctest.status: While running git apply --index -3 -p1; error: patch ...
4 years, 10 months ago (2016-02-25 16:10:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733363002/20001
4 years, 10 months ago (2016-02-25 16:43:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 16:44:55 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 16:45:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbd60c5d7166c62b8540382f857ba6de185228b7
Cr-Commit-Position: refs/heads/master@{#34299}

Powered by Google App Engine
This is Rietveld 408576698