Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Issue 1733353004: Introduce WorkerBackingThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
index ee004373e27cb1feb36b7c5d63f1aaac245ad1ca..d6197f7432e1a02fe54c799b5f94e03a40630def 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
@@ -7,6 +7,7 @@
#include "bindings/core/v8/ScriptCallStack.h"
#include "bindings/core/v8/V8GCController.h"
#include "core/inspector/ConsoleMessage.h"
+#include "core/workers/WorkerBackingThread.h"
#include "core/workers/WorkerReportingProxy.h"
#include "core/workers/WorkerThreadStartupData.h"
#include "platform/NotImplemented.h"
@@ -100,25 +101,13 @@ public:
WorkerThreadForTest(
WorkerLoaderProxyProvider* mockWorkerLoaderProxyProvider,
WorkerReportingProxy& mockWorkerReportingProxy)
- : WorkerThread(WorkerLoaderProxy::create(mockWorkerLoaderProxyProvider), mockWorkerReportingProxy)
- , m_thread(WebThreadSupportingGC::create("Test thread"))
+ : WorkerThread(WorkerLoaderProxy::create(mockWorkerLoaderProxyProvider), mockWorkerReportingProxy, WorkerBackingThread::create("Test thread"))
, m_scriptLoadedEvent(adoptPtr(new WaitableEvent()))
{
}
~WorkerThreadForTest() override { }
- // WorkerThread implementation:
- WebThreadSupportingGC& backingThread() override
- {
- return *m_thread;
- }
- void willDestroyIsolate() override
- {
- V8GCController::collectAllGarbageForTesting(v8::Isolate::GetCurrent());
- WorkerThread::willDestroyIsolate();
- }
-
PassRefPtrWillBeRawPtr<WorkerGlobalScope> createWorkerGlobalScope(PassOwnPtr<WorkerThreadStartupData> startupData) override
{
return adoptRefWillBeNoop(new FakeWorkerGlobalScope(startupData->m_scriptURL, startupData->m_userAgent, this, startupData->m_starterOriginPrivilegeData.release(), startupData->m_workerClients.release()));
@@ -135,7 +124,6 @@ public:
}
private:
- OwnPtr<WebThreadSupportingGC> m_thread;
OwnPtr<WaitableEvent> m_scriptLoadedEvent;
};

Powered by Google App Engine
This is Rietveld 408576698