src/runtime/runtime-regexp.cc - Issue 1733333002: Clear recorded slots when creating filler objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-regexp.cc

Issue 1733333002: Clear recorded slots when creating filler objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-regexp.cc

diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc

index df86aa870cb659eb057c2be97b3c9c06a2355f0e..1c323e34b79144f7403be4e0371d0cfd50ea0672 100644

--- a/src/runtime/runtime-regexp.cc

+++ b/src/runtime/runtime-regexp.cc

@@ -642,7 +642,7 @@ MUST_USE_RESULT static Object* StringReplaceGlobalRegExpWithEmptyString(

// TODO(hpayer): We should shrink the large object page if the size

// of the object changed significantly.

if (!heap->lo_space()->Contains(*answer)) {

- heap->CreateFillerObjectAt(end_of_string, delta);

+ heap->CreateFillerObjectAt(end_of_string, delta, kNoRecordedSlots);

}

heap->AdjustLiveBytes(*answer, -delta, Heap::CONCURRENT_TO_SWEEPER);

return *answer;