net/quic/quic_rst_stream_error_list.h - Issue 17333003: Pretty-print QUIC CONNECTION_CLOSE and RST_STREAM error codes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/quic_rst_stream_error_list.h

Issue 17333003: Pretty-print QUIC CONNECTION_CLOSE and RST_STREAM error codes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Wrap Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards)

	6 // inside a macro to generate enum.

	7

	8 // This file contains the list of QUIC RST_STREAM errors.

	9

	10 QUIC_RST_STREAM_ERROR(STREAM_NO_ERROR)
	eroman 2013/06/18 19:39:17 [optional] put this in the enum block [optional] put this in the enum block Ryan Hamilton 2013/06/19 16:59:11 Hm. I could definitely go either way. I'm inclin Show quoted text On 2013/06/18 19:39:17, eroman wrote: > [optional] put this in the enum block Hm. I could definitely go either way. I'm inclined to leave it in the list so that in net-internals we see quic_error = 0 (NO_ERROR) instead of quic_error = 0. But perhaps that's not actually important? Ok, done. (But I am curious what you think)
	11

	12 // There was some server error which halted stream processing.

	13 QUIC_RST_STREAM_ERROR(SERVER_ERROR_PROCESSING_STREAM)

	14 // We got two fin or reset offsets which did not match.

	15 QUIC_RST_STREAM_ERROR(MULTIPLE_TERMINATION_OFFSETS)

	16 // We got bad payload and can not respond to it at the protocol level.

	17 QUIC_RST_STREAM_ERROR(BAD_APPLICATION_PAYLOAD)

	18 // Stream closed due to connection error. No reset frame is sent when this

	19 // happens.

	20 QUIC_RST_STREAM_ERROR(STREAM_CONNECTION_ERROR)

	21 // GoAway frame sent. No more stream can be created.

	22 QUIC_RST_STREAM_ERROR(STREAM_PEER_GOING_AWAY)

	23

	24 // No error. Used as bound while iterating.

	25 QUIC_RST_STREAM_ERROR(STREAM_LAST_ERROR)
	eroman 2013/06/18 19:39:17 put this in the enum block. put this in the enum block. Ryan Hamilton 2013/06/19 16:59:11 Done. Show quoted text On 2013/06/18 19:39:17, eroman wrote: > put this in the enum block. Done.
OLD	NEW

« net/quic/quic_error_list.h ('K') | « net/quic/quic_protocol.h ('k') | no next file » | no next file with comments »