Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1733223002: Add -lrt flag to enable the usage of clock_gettime. Enable RawCodec for ChromeOS (Closed)

Created:
4 years, 10 months ago by yujieqin
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add -lrt flag for ChromeOS to enable the usage of clock_gettime. Enable RawCodec for ChromeOS BUG=b/26813410 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733223002 Committed: https://skia.googlesource.com/skia/+/ddb347b63c72141378fc8bd25fa40d6dac9fe916

Patch Set 1 #

Patch Set 2 : Only enable -lrt for chromeos #

Total comments: 2

Patch Set 3 : Remove old comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gyp/codec.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yujieqin
4 years, 10 months ago (2016-02-25 09:49:29 UTC) #4
scroggo
lgtm https://codereview.chromium.org/1733223002/diff/20001/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/1733223002/diff/20001/gyp/common_variables.gypi#newcode65 gyp/common_variables.gypi:65: # FIXME: fix the support for ChromeOS [DNG ...
4 years, 10 months ago (2016-02-25 12:59:52 UTC) #5
yujieqin
https://codereview.chromium.org/1733223002/diff/20001/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/1733223002/diff/20001/gyp/common_variables.gypi#newcode65 gyp/common_variables.gypi:65: # FIXME: fix the support for ChromeOS [DNG SDK ...
4 years, 10 months ago (2016-02-25 13:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733223002/40001
4 years, 10 months ago (2016-02-25 13:19:24 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:42:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ddb347b63c72141378fc8bd25fa40d6dac9fe916

Powered by Google App Engine
This is Rietveld 408576698