Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1733213002: Revert of [coverage] Filter some files from instrumentation. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [coverage] Filter some files from instrumentation. (patchset #4 id:60001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: Prevents using goma with make. Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} > > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a > Cr-Commit-Position: refs/heads/master@{#34253} > > Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a > Cr-Commit-Position: refs/heads/master@{#34272} TBR=tandrii@chromium.org,kjellander@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Committed: https://crrev.com/5683974925930bdc634c6b1c029a77faba1e1ae0 Cr-Commit-Position: refs/heads/master@{#34275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -77 lines) Patch
D build/coverage_wrapper.py View 1 chunk +0 lines, -28 lines 0 comments Download
M build/standalone.gypi View 8 chunks +24 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [coverage] Filter some files from instrumentation.
4 years, 10 months ago (2016-02-25 08:20:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733213002/1
4 years, 10 months ago (2016-02-25 08:20:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 08:20:31 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 08:21:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5683974925930bdc634c6b1c029a77faba1e1ae0
Cr-Commit-Position: refs/heads/master@{#34275}

Powered by Google App Engine
This is Rietveld 408576698