Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 1733193002: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
index e4c1adc78ae931f044c7bde788a2ac5dd2880b6d..2752408ece89a05513ff67ad165a8d0a2ec204e7 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
@@ -53,32 +53,6 @@
namespace blink {
-template<typename T>
-class HarfBuzzScopedPtr {
- STACK_ALLOCATED();
- WTF_MAKE_NONCOPYABLE(HarfBuzzScopedPtr);
-public:
- typedef void (*DestroyFunction)(T*);
-
- HarfBuzzScopedPtr(T* ptr, DestroyFunction destroy)
- : m_ptr(ptr)
- , m_destroy(destroy)
- {
- ASSERT(m_destroy);
- }
- ~HarfBuzzScopedPtr()
- {
- if (m_ptr)
- (*m_destroy)(m_ptr);
- }
-
- T* get() { return m_ptr; }
- void set(T* ptr) { m_ptr = ptr; }
-private:
- T* m_ptr;
- DestroyFunction m_destroy;
-};
-
static inline float harfBuzzPositionToFloat(hb_position_t value)
{
return static_cast<float>(value) / (1 << 16);

Powered by Google App Engine
This is Rietveld 408576698